Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug preventing Mantid from processing algorithms from some indirect/inelastic interfaces #37404

Merged
merged 4 commits into from
May 24, 2024

Conversation

adriazalvarez
Copy link
Contributor

Description of work

Recently algortihms validators stopped checking against long type, #37196
Some classes that use properties of type IntArrayProperty but were declared as std::vector<long> from cpp were not able to run the algorithms, we have detected that it affected:

  • Symmetrise interface
  • ISIS Diagnostic
  • Isis Diffraction Reduction
  • Isis Energy Transfer

Summary of work

There is no associated issue.

Further detail of work

To test:

  • Check that the affected interfaces can execute the algorithm without an error message raising.

Reviewer

Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.

Code Review

  • Is the code of an acceptable quality?
  • Does the code conform to the coding standards?
  • Are the unit tests small and test the class in isolation?
  • If there is GUI work does it follow the GUI standards?
  • If there are changes in the release notes then do they describe the changes appropriately?
  • Do the release notes conform to the release notes guide?

Functional Tests

  • Do changes function as described? Add comments below that describe the tests performed?
  • Do the changes handle unexpected situations, e.g. bad input?
  • Has the relevant (user and developer) documentation been added/updated?

Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.

Gatekeeper

If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.

@adriazalvarez adriazalvarez added Bug Issues and pull requests that are regressions or would be considered a bug by users (e.g. crashing) Indirect/Inelastic Issues and pull requests related to indirect or inelastic Extra Attention Testers and Gate keepers should pay extra attention as this affects core aspects. ISIS Team: Spectroscopy Issue and pull requests managed by the Spectroscopy subteam at ISIS labels May 20, 2024
@adriazalvarez adriazalvarez added this to the Release 6.10 milestone May 20, 2024
@adriazalvarez adriazalvarez changed the title Bug preventing Mantid from processing some algorithms from some indirect/inelastic interfaces Bug preventing Mantid from processing algorithms from some indirect/inelastic interfaces May 20, 2024
@adriazalvarez adriazalvarez marked this pull request as ready for review May 21, 2024 09:10
@robertapplin robertapplin self-assigned this May 21, 2024
Copy link
Contributor

@robertapplin robertapplin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this so quickly, and spotting it in the first place! I just had one small suggestion

Copy link
Contributor

@robertapplin robertapplin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested Indirect Data reduction, diffraction reduction, symmetrise and ISIS diagnostics - all of the working as expected. Code looks good, thanks for the fix

@SilkeSchomann SilkeSchomann self-assigned this May 24, 2024
@SilkeSchomann SilkeSchomann merged commit 645b183 into release-next May 24, 2024
10 checks passed
@SilkeSchomann SilkeSchomann deleted the symmetrise_bug branch May 24, 2024 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Issues and pull requests that are regressions or would be considered a bug by users (e.g. crashing) Extra Attention Testers and Gate keepers should pay extra attention as this affects core aspects. Indirect/Inelastic Issues and pull requests related to indirect or inelastic ISIS Team: Spectroscopy Issue and pull requests managed by the Spectroscopy subteam at ISIS
Projects
Status: Merged
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants