Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shuttercount Frontend - Part 2 of Part 1 of 2 #2203

Merged
merged 8 commits into from
May 20, 2024

Conversation

JackEAllen
Copy link
Collaborator

@JackEAllen JackEAllen commented May 13, 2024

Issue

Closes #2094

Description

Add a description of the changes made.
Create basic front end to allow a user to load in ShutterCount files alongside a sample.
The GUI interface design for loading ShuttterCount files is temporary and will be reworked in the future to bring related files closer together.

Testing

Describe the tests that were used to verify your changes.

  • Try Loading ShutterCount files into mantid Imaging
  • Loading in an unexpected format such as a spectra file triggers error dialog window on selection
  • GUI tests pass
  • Tests Pass

Acceptance Criteria

How should the reviewer test your changes?

  • All tests pass
  • ShutterCount files can be loaded into Mantid Imaging from the Loading Dialog
  • Loading in an unexpected format such as a spectra file triggers error dialog window on selection
  • ShutterCount Files can be loaded for a given stack after loading sample File > Load ShutterCount file for stack...

Documentation

How have you changed the documentation to reflect your changes? All changes should be noted in the appropriate file in docs/release_notes

Release Notes: docs/release_notes/next/feature-2094-Load_ShutterCount_files_front-end

@JackEAllen JackEAllen changed the title Shuttercount Frontend - Part 2 or Part 1 Shuttercount Frontend - Part 2 of Part 1 May 13, 2024
@JackEAllen JackEAllen changed the title Shuttercount Frontend - Part 2 of Part 1 Shuttercount Frontend - Part 2 of Part 1 of 2 May 13, 2024
@JackEAllen JackEAllen force-pushed the shuttercount_frontend branch 2 times, most recently from aa23fca to ad69db4 Compare May 14, 2024 16:32
@JackEAllen JackEAllen self-assigned this May 14, 2024
@coveralls
Copy link

coveralls commented May 14, 2024

Coverage Status

coverage: 72.735% (+0.005%) from 72.73%
when pulling 1a8df3d on shuttercount_frontend
into 2a6191e on main.

@JackEAllen JackEAllen marked this pull request as ready for review May 15, 2024 10:02
@JackEAllen JackEAllen changed the title Shuttercount Frontend - Part 2 of Part 1 of 2 DONT MERGE: Shuttercount Frontend - Part 2 of Part 1 of 2 May 16, 2024
@JackEAllen JackEAllen changed the title DONT MERGE: Shuttercount Frontend - Part 2 of Part 1 of 2 Shuttercount Frontend - Part 2 of Part 1 of 2 May 16, 2024
@samtygier-stfc samtygier-stfc added this pull request to the merge queue May 20, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 20, 2024
@samtygier-stfc samtygier-stfc added this pull request to the merge queue May 20, 2024
Merged via the queue into main with commit 619bdd4 May 20, 2024
8 checks passed
@samtygier-stfc samtygier-stfc deleted the shuttercount_frontend branch May 20, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Load Spectrum Shutter Counts into MI Per Stack [Part 1]
3 participants