Some tests for Spectrum viewer #2220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: JackEAllen <jack.allen@stfc.ac.uk> Co-authored-by: Mike Sullivan <michael.sullivan@stfc.ac.uk>
Co-authored-by: JackEAllen <jack.allen@stfc.ac.uk> Co-authored-by: Mike Sullivan <michael.sullivan@stfc.ac.uk>
Co-authored-by: JackEAllen <jack.allen@stfc.ac.uk> Co-authored-by: Mike Sullivan <michael.sullivan@stfc.ac.uk>
samtygier-stfc
force-pushed
the
2032-spec-viewer-tests
branch
from
04af1e6
to
d0f137a
Compare
ashmeigh
approved these changes
Jun 7, 2024
There was a problem hiding this comment.
The acceptance criteria were met. I ran the new tests which confirmed the spectrum viewer operates as expected with data. Interactions with ROIs are seamless, clicking on ROIs updates coordinates appropriately, and navigating between ROI and Image tabs consistently displays the same ROI. The code changes was also fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Work on #2032
Description
Some refactoring and tests for
SpectrumROITests for
handle_roi_clickedTesting
Adds some tests
Acceptance Criteria
Open spectrum viewer with data
Add some ROIs
Check that clicking on ROIs updates coords in the properties
Check that the same ROI is showing when moving back and forth between ROIs and Image tabs
Documentation
Not needed