Spectrum viewer refactoring - Moving logic from the view to the presenter

[MikeSullivan7]

Issue

Closes #2224

Description

The following functions have been moved from the view to the presenter:

• do_adjust_roi
• handle_storing_current_roi_name_on_tab_change
• parts of on_visibility_change

some new functions have been made to help with testing:

• presenter.check_action
• view.get_roi_properties_spinboxes
• view.setup_roi_properties_spinboxes

The logic for presenter.handle_storing_current_roi_name_on_tab_change has also been simplified.

Unit tests for the following functions have been added:

• presenter.change_selected_menu_option
• presenter.do_adjust_roi
• presenter.handle_storing_current_roi_name_on_tab_change
• presenter.refresh_spectrum_plot
• presenter.redraw_all_rois
• presenter.handle_roi_clicked
• handle_enable_normalised

Testing

make check

Acceptance Criteria

Open MI and load some data into it (with spectrum file if possible) and make sure that the functionality is the same as it was before this refactor and no bugs have been introduced.

run make check or make test and check that all tests pass

Documentation

Will add release note

[coveralls]

coverage: 72.978% (+0.3%) from 72.705%
when pulling 529ee6c on 2224_spectrum_viewer_refactoring
into 06f179e on main.

[samtygier-stfc]

Not a full review, just a quick thing that i noticed

[samtygier-stfc]

All looks good. Passes tests.

[coveralls]

coverage: 72.975% (+0.3%) from 72.705%
when pulling b09bebe on 2224_spectrum_viewer_refactoring
into 06f179e on main.