Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove sarepy from dependancies #2232

Merged
merged 2 commits into from
Jun 24, 2024
Merged

Remove sarepy from dependancies #2232

merged 2 commits into from
Jun 24, 2024

Conversation

samtygier-stfc
Copy link
Collaborator

Issue

We migrated from sarepy to algotom in #1023, but had to keep the dependency to enable building old documentation.

This was resolved in #1150, so now its possible to remove the package

Description

Remove sarepy from dependancies and remove dtasev channel

Acceptance Criteria

Automated testing should all pass

Documentation

Not needed

@samtygier-stfc samtygier-stfc marked this pull request as ready for review June 20, 2024 13:04
@coveralls
Copy link

Coverage Status

coverage: 73.019%. remained the same
when pulling a884c8f on 1150-remove-sarepy
into b866326 on main.

Copy link
Collaborator

@JackEAllen JackEAllen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I did notice that we need to update some a Docstring and tooltip that still reference Sarepy that we should swap to say using Algotom which make sense to do as part of this PR.

mantidimaging/core/operations/remove_stripe_filtering/remove_stripe_filtering.filter_func Line 49:

:param filtering_dim: Whether to use a 1D or 2D low-pass filter. This
   uses different Sarepy methods.

and:
mantidimaging/core/operations/remove_stripe_filtering/remove_stripe_filtering.register_gui Line 121:

tooltip="Whether to use a 1D or 2D low-pass filter. "
    "This uses different Sarepy methods")

@coveralls
Copy link

Coverage Status

coverage: 72.992% (-0.03%) from 73.019%
when pulling b141b19 on 1150-remove-sarepy
into b866326 on main.

Copy link
Collaborator

@JackEAllen JackEAllen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for swapping the last few references from sarepy to algotom. Looks good!

@JackEAllen JackEAllen added this pull request to the merge queue Jun 24, 2024
Merged via the queue into main with commit 5e7c5a3 Jun 24, 2024
8 checks passed
@JackEAllen JackEAllen deleted the 1150-remove-sarepy branch June 24, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants