Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Some type checking for #2213
Description
This adds some type annotations to
TableModel
. This is slightly awkward because the data rows are a heterogenous list, and there is not way to strictly type its elements. We can't switch to a tuple, because they need to be mutable (maybe we can. but it is more code change).So add
ElementType
andRowType
, which limit the types, but don't understand the positions. and add anoverload
edget_element()
that fixes the type based on the literal value of the column argument.Also some changes in the view to access things though
get_element()
andset_element()
Acceptance Criteria
Existing tests should all still pass
Play around with adding, removing and renaming ROIs
Documentation
Not needed