-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[@mantine/core] Image: fix possible permanent placeholder after hydration #630
Conversation
@@ -1 +1 @@ | |||
v14.9.0 | |||
v14.17.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any reason to change node version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was stuck with an error stating that a dependency required node >= 14.17 during my first yarn install
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, then let's leave it in 14.17 then
Thanks for a PR, have you tested it to work in ssr environment, e.g. in next template? |
@rtivital I encountered the issue with my stack which is viteJS + SSR and with the fix, the problem with placeholder disappeared. |
Okay, I'll run some more tests with it then |
Oh btw, did you mean testing manually with other SSR environment? I couldn't figure out how to add a test with an html string and an hydration using |
Yes, I do not think it is possible to check it within jest-dom environment, so it should be checked manually at least in Next.js |
I've checked with next, it works fine |
This PR fixes #629