Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[@mantine/core] Menu: fix keboard Esc from closing menu and modal when in a modal #6580

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

ocshawn
Copy link
Contributor

@ocshawn ocshawn commented Jul 24, 2024

Fixes #6528

Things to note:

  • Added storybook page with Menu in Modal
  • Adds data-mantine-stop-propagation to interactive menu items to stop keyboard events from bubbling up
  • Code Formatting changes provided by prettier

@rtivital rtivital merged commit dcba0a4 into mantinedev:master Aug 6, 2024
1 check passed
@rtivital
Copy link
Member

rtivital commented Aug 6, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mantine Menu in Modal keyboard accessibility
2 participants