Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[R4R]-{develop}: Fix typos #1300

Merged
merged 4 commits into from
Aug 1, 2023
Merged

[R4R]-{develop}: Fix typos #1300

merged 4 commits into from
Aug 1, 2023

Conversation

omahs
Copy link
Contributor

@omahs omahs commented Jul 18, 2023

Fix: typos

@omahs omahs requested a review from wukongcheng as a code owner July 18, 2023 10:45
@omahs omahs mentioned this pull request Jul 18, 2023
Closed
@Sha3nS Sha3nS changed the title Fix: typos [R4R]-{develop}Fix: typos Jul 19, 2023
@Sha3nS Sha3nS changed the title [R4R]-{develop}Fix: typos [R4R]-{develop}: Fix typos Jul 19, 2023
Tri-stone
Tri-stone reviewed Jul 19, 2023
View reviewed changes
ops/README.md

Grafana data is not currently saved. Any modifications or additions will be lost on container restart.

InfluxDB is persisting data to a Docker volume.

**Stopping the project removing the containers will not clear this volume**

To remove the influxdb and grafana data, run a commands like
To remove the influxdb and grafana data, run a command like
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

run commands like may be better

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Tri-stone I can change this but it's "a" command so normally it should be singular

Tri-stone
Tri-stone approved these changes Aug 1, 2023
View reviewed changes
Copy link
Collaborator

@Tri-stone Tri-stone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Tri-stone Tri-stone merged commit fc30663 into mantlenetworkio:develop Aug 1, 2023
1 check failed
Sha3nS added a commit that referenced this pull request Aug 2, 2023
@Sha3nS @omahs @Ethanncnm
V0.4.3/sync develop (#1323)
3b6e38e 
* [R4R]-{develop}: Fix typos (#1300)

* [R4R] - {license}: add DA license (#1263)

* add DA license

* add DA license and FraudProof LICENSE

* fix DA proof

---------

Co-authored-by: omahs <73983677+omahs@users.noreply.github.com>
Co-authored-by: ethan <101823964+Ethanncnm@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tri-stone Tri-stone Tri-stone approved these changes

@wukongcheng wukongcheng wukongcheng approved these changes

Assignees
No one assigned
Labels
2-reviewers M-l2geth M-ops
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@omahs @wukongcheng @Tri-stone