Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

R4R: fix panic in traceCall #1305

Merged
merged 1 commit into from
Jul 20, 2023
Merged

R4R: fix panic in traceCall #1305

merged 1 commit into from
Jul 20, 2023
+1 −1

Conversation

abelliumnt
Copy link
Collaborator

Goals of PR

Core changes:

  • add nil pointer checker in traceCall

Notes:

  • Write notes here

Related Issues:

Tri-stone
Tri-stone approved these changes Jul 20, 2023
View reviewed changes
Copy link
Collaborator

@Tri-stone Tri-stone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abelliumnt abelliumnt merged commit f5e3244 into develop Jul 20, 2023
@abelliumnt abelliumnt deleted the lhy/fix-panic-tracecall branch July 20, 2023 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sha3nS Sha3nS Sha3nS approved these changes

@Tri-stone Tri-stone Tri-stone approved these changes

@byteflyfunny byteflyfunny byteflyfunny approved these changes

@guoshijiang guoshijiang Awaiting requested review from guoshijiang

Assignees
No one assigned
Labels
2-reviewers C-Protocol-Critical M-l2geth
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@abelliumnt @byteflyfunny @Tri-stone @guoshijiang @Sha3nS