Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[R4R]-{develop}-[gasoracle]impr: modify token_ratio from int64 to float64 for metrics #1310

Merged
merged 1 commit into from
Jul 21, 2023
Merged

[R4R]-{develop}-[gasoracle]impr: modify token_ratio from int64 to float64 for metrics #1310

merged 1 commit into from
Jul 21, 2023

Conversation

Tri-stone
Copy link
Collaborator

Goals of PR

Core changes:

  • modify token_ratio from int64 to float64 for metrics
  • solve the false alarm from monitor

Issues:

  • when using the int64 data type, the changes on the decimal places will be eliminated

Solutions:

  • replace metrics.Gauge with metrics.GaugeFloat64 to store token_ratio

Results:
截屏2023-07-21 11 30 54

@wukongcheng wukongcheng merged commit a037479 into develop Jul 21, 2023
@wukongcheng wukongcheng deleted the leo/improve_metrics_for_token_ratio branch July 21, 2023 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guoshijiang guoshijiang guoshijiang approved these changes

@byteflyfunny byteflyfunny byteflyfunny approved these changes

@wukongcheng wukongcheng wukongcheng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Tri-stone @wukongcheng @byteflyfunny @guoshijiang