Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Gravatar support #37

Closed
jayvdb opened this issue Dec 19, 2017 · 9 comments
Closed

Add Gravatar support #37

jayvdb opened this issue Dec 19, 2017 · 9 comments
Labels
googlecodein New Website Requests for supporting a new website

Comments

@jayvdb
Copy link
Collaborator

jayvdb commented Dec 19, 2017

Gravatar supports profile usernames.

@seeeturtle
Copy link
Collaborator

this issue is related with getting profile image of openhub since it set profile image as gravatar.

@pavi2410
Copy link
Contributor

pavi2410 commented Jan 5, 2018

I can do this. I claimed this task on GCI.

@jayvdb
Copy link
Collaborator Author

jayvdb commented Jan 6, 2018

@pavi2410
Copy link
Contributor

pavi2410 commented Jan 6, 2018

Is it OK if I parse the user page to get avatar image?

@jayvdb
Copy link
Collaborator Author

jayvdb commented Jan 7, 2018

It is ok if you parse the page to get the avatar, but isnt ideal.
Ideally we use the gravatar API, but that can be done in a different task.
See pypi for some packages which may help.

@pavi2410
Copy link
Contributor

pavi2410 commented Jan 12, 2018

Let's start from first. What should I do? The issue doesn't describe the problem

@manu-chroma
Copy link
Owner

Check:
#72 (comment)
#72 (comment)

you need to fix your commit message and I think we will be able to merge then.

@pavi2410
Copy link
Contributor

Should I add a method to fetch gravatar image from username? If it succeeds, then return the gravatar image, else scrape the image. But we cannot guarantee that a single person has the same username in different services. For eg, if a person A has username XYZ in open hub, but the same username on gravatar is of person B.

@manu-chroma
Copy link
Owner

what you've done is good to go for now. just fix the commit message to include the issues you addressed. #74 (comment)

But we cannot guarantee that a single person has the same username in different services. For eg, if a person A has username XYZ in open hub, but the same username on gravatar is of person B.

that's is why we won't be doing this. integrating gravatar's from https://en.gravatar.com/ will be considered in a separate issue.

@jayvdb jayvdb added the New Website Requests for supporting a new website label Mar 20, 2018
kx-chen added a commit to kx-chen/username-availability-checker that referenced this issue Oct 25, 2018
Add support for profile pictures and username checking for gravatar.

Closes manu-chroma#37
kx-chen added a commit to kx-chen/username-availability-checker that referenced this issue Oct 25, 2018
Add support for profile pictures and username checking for gravatar.

Closes manu-chroma#37
kx-chen added a commit to kx-chen/username-availability-checker that referenced this issue Oct 25, 2018
Add support for profile pictures and username checking for gravatar.

Closes manu-chroma#37
kx-chen added a commit to kx-chen/username-availability-checker that referenced this issue Oct 25, 2018
Add support for profile pictures and username checking for gravatar.

Closes manu-chroma#37
kx-chen added a commit to kx-chen/username-availability-checker that referenced this issue Oct 27, 2018
Add support for profile pictures and username checking for gravatar.

Closes manu-chroma#37
jayvdb pushed a commit to kx-chen/username-availability-checker that referenced this issue Oct 30, 2018
Add support for profile pictures and username checking for gravatar.

Closes manu-chroma#37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
googlecodein New Website Requests for supporting a new website
Projects
None yet
Development

No branches or pull requests

4 participants