Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rescaling issues #5

Closed
sgentile opened this issue Nov 4, 2017 · 10 comments
Closed

rescaling issues #5

sgentile opened this issue Nov 4, 2017 · 10 comments

Comments

@sgentile
Copy link

sgentile commented Nov 4, 2017

Both in your demo's and locally, the way the icons are positioned at times do not match their location. ie. you can easily see markers in the water at zoom levels - as you zoom closer they are back on land where they belong.

Is this something you are going to fix ?

@manubb
Copy link
Owner

manubb commented Nov 4, 2017

I am not sure i understand the issue you are reporting. In demos on US and french cities, i use an algorithm that avoids marker overlaps and at lower zoom levels, the fact that marker are not at their precise location is expected. Can you post a screenshot displaying your problem?

@sgentile
Copy link
Author

sgentile commented Nov 5, 2017

that explains it - I would like to disable that so that it's on the right latlng, ie. precision for what I need is more important than overlay at higher zoom levels.

what would you recommend I change to enable that ?

Thanks!

@sgentile
Copy link
Author

sgentile commented Nov 5, 2017 via email

@manubb
Copy link
Owner

manubb commented Nov 5, 2017

Here is a simplified version of us-cities demo:
https://manubb.github.io/Leaflet.PixiOverlay/us-cities-simple.html
that you can use as a base for what you want to do.

Note that the feature we are talking of is not a part of the main library ;-)

@sgentile
Copy link
Author

sgentile commented Nov 5, 2017 via email

@sgentile
Copy link
Author

sgentile commented Nov 5, 2017 via email

@sgentile
Copy link
Author

sgentile commented Nov 5, 2017 via email

@manubb
Copy link
Owner

manubb commented Nov 5, 2017

Concerning selection, i cannot recommend anything as this is really app specific.

If the number of markers is small, you can simply use Pixi.js interactivity.

If you want to display many markers you can have a look at the code of us-cities demo to see how interactivity is implemented.
(I am using quadtrees to find which marker(s) is(are) under the click or under the pointer. Since markers are static in your project, the code would be much simpler and you only need to use one quadtree.)

@manubb
Copy link
Owner

manubb commented Nov 8, 2017

I'm gonna close this. Reopen if you need to.

@manubb manubb closed this as completed Nov 8, 2017
@sgentile
Copy link
Author

sgentile commented Nov 8, 2017

Thanks again for your help - I put a sample together for anyone else interested in trying this:

https://github.com/sgentile/PixieOverlaySample

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants