Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

webpage.py: note error in versions checkout is OK #211

Merged
merged 3 commits into from Apr 18, 2019
Merged

webpage.py: note error in versions checkout is OK #211

merged 3 commits into from Apr 18, 2019

Conversation

dhimmel
Copy link
Member

@dhimmel dhimmel commented Apr 18, 2019

Closes #183

@dhimmel
Copy link
Member Author

dhimmel commented Apr 18, 2019

Tested 6ca03b7 locally by checking out a branch upstream/output that does not have the v directory. See the output below:

>>> python build/webpage.py --checkout=upstream/output
Attempting checkout with the following command:
git --work-tree=webpage checkout upstream/output -- v
Checkout returned a nonzero exit status. See stderr:
error: pathspec 'v' did not match any file(s) known to git.
Manubot note: if there are no preexisting webpage versions (like for a newly created manuscript), the pathspec error above is expected and can be safely ignored.

The message is not shown if trying to check out a missing branch for example:

>>> python build/webpage.py --checkout=missing-branch
Attempting checkout with the following command:
git --work-tree=webpage checkout missing-branch -- v
Checkout returned a nonzero exit status. See stderr:
fatal: invalid reference: missing-branch

@slochower
Copy link
Collaborator

Good usability improvement.

@dhimmel dhimmel merged commit 0399e5f into manubot:master Apr 18, 2019
@dhimmel dhimmel deleted the issue-183 branch April 18, 2019 19:28
dhimmel added a commit that referenced this pull request Apr 18, 2019
@dhimmel
webpage.py: note to ignore error in versions checkout
68046b9 
This build is based on
0399e5f.

This commit was created by the following Travis CI build and job:
https://travis-ci.com/manubot/rootstock/builds/108895621
https://travis-ci.com/manubot/rootstock/jobs/194120819

[ci skip]

The full commit message that triggered this build is copied below:

webpage.py: note to ignore error in versions checkout

Merges #211
Closes #183
dhimmel added a commit that referenced this pull request Apr 18, 2019
@dhimmel
webpage.py: note to ignore error in versions checkout
87d253c 
This build is based on
0399e5f.

This commit was created by the following Travis CI build and job:
https://travis-ci.com/manubot/rootstock/builds/108895621
https://travis-ci.com/manubot/rootstock/jobs/194120819

[ci skip]

The full commit message that triggered this build is copied below:

webpage.py: note to ignore error in versions checkout

Merges #211
Closes #183
slochower added a commit to slochower/smirnoff-host-guest-manuscript that referenced this pull request May 15, 2019
@slochower
Rootstock 2019 05 15 (#36)
d62afc4 
* webpage.py: note to ignore error in versions checkout

Merges manubot/rootstock#211
Closes manubot/rootstock#183

* Use Athena to build PDF, if Docker installed

Merges manubot/rootstock#210
Closes manubot/rootstock#170

More information about Athena is available at
https://github.com/arachnys/athenapdf

Based on meta-review commit:
greenelab/meta-review@cffcfea

* Add meta review link to readme

Merges manubot/rootstock#217
Closes manubot/rootstock#216

* Increase shared memory of athenapdf container

Merges manubot/rootstock#220
Closes arachnys/athenapdf#195

Increase --shm-size from the default value of 64m to 1g when
running the athenapdf Docker image. Resolves athena issue:
`The renderer process has crashed`

Switch to using equal sign to separate Docker arguments
and values for consistency.
https://stackoverflow.com/q/50319060/4651668

* CSL author macro: substitute editor/venue

Merges manubot/rootstock#219

Ensures there is a newline between the title and venue,
when authors are missing.
Closes manubot/rootstock#218
Supersedes manubot/rootstock#158

Substitutes editors for authors when authors are missing.
Editors are labeled like "Sönke Bartling, Sascha Friesike (editors)".
slochower added a commit to slochower/smirnoff-host-guest-manuscript that referenced this pull request May 15, 2019
@slochower
Rootstock 2019 05 15 (#36)
953ebaf 
This build is based on
d62afc4.

This commit was created by the following Travis CI build and job:
https://travis-ci.com/slochower/smirnoff-host-guest-manuscript/builds/532938787
https://travis-ci.com/slochower/smirnoff-host-guest-manuscript/jobs/532938788

[ci skip]

The full commit message that triggered this build is copied below:

Rootstock 2019 05 15 (#36)

* webpage.py: note to ignore error in versions checkout

Merges manubot/rootstock#211
Closes manubot/rootstock#183

* Use Athena to build PDF, if Docker installed

Merges manubot/rootstock#210
Closes manubot/rootstock#170

More information about Athena is available at
https://github.com/arachnys/athenapdf

Based on meta-review commit:
greenelab/meta-review@cffcfea

* Add meta review link to readme

Merges manubot/rootstock#217
Closes manubot/rootstock#216

* Increase shared memory of athenapdf container

Merges manubot/rootstock#220
Closes arachnys/athenapdf#195

Increase --shm-size from the default value of 64m to 1g when
running the athenapdf Docker image. Resolves athena issue:
`The renderer process has crashed`

Switch to using equal sign to separate Docker arguments
and values for consistency.
https://stackoverflow.com/q/50319060/4651668

* CSL author macro: substitute editor/venue

Merges manubot/rootstock#219

Ensures there is a newline between the title and venue,
when authors are missing.
Closes manubot/rootstock#218
Supersedes manubot/rootstock#158

Substitutes editors for authors when authors are missing.
Editors are labeled like "Sönke Bartling, Sascha Friesike (editors)".
slochower added a commit to slochower/smirnoff-host-guest-manuscript that referenced this pull request May 15, 2019
@slochower
Rootstock 2019 05 15 (#36)
63b2e3b 
This build is based on
d62afc4.

This commit was created by the following Travis CI build and job:
https://travis-ci.com/slochower/smirnoff-host-guest-manuscript/builds/532938787
https://travis-ci.com/slochower/smirnoff-host-guest-manuscript/jobs/532938788

[ci skip]

The full commit message that triggered this build is copied below:

Rootstock 2019 05 15 (#36)

* webpage.py: note to ignore error in versions checkout

Merges manubot/rootstock#211
Closes manubot/rootstock#183

* Use Athena to build PDF, if Docker installed

Merges manubot/rootstock#210
Closes manubot/rootstock#170

More information about Athena is available at
https://github.com/arachnys/athenapdf

Based on meta-review commit:
greenelab/meta-review@cffcfea

* Add meta review link to readme

Merges manubot/rootstock#217
Closes manubot/rootstock#216

* Increase shared memory of athenapdf container

Merges manubot/rootstock#220
Closes arachnys/athenapdf#195

Increase --shm-size from the default value of 64m to 1g when
running the athenapdf Docker image. Resolves athena issue:
`The renderer process has crashed`

Switch to using equal sign to separate Docker arguments
and values for consistency.
https://stackoverflow.com/q/50319060/4651668

* CSL author macro: substitute editor/venue

Merges manubot/rootstock#219

Ensures there is a newline between the title and venue,
when authors are missing.
Closes manubot/rootstock#218
Supersedes manubot/rootstock#158

Substitutes editors for authors when authors are missing.
Editors are labeled like "Sönke Bartling, Sascha Friesike (editors)".
adebali pushed a commit to CompGenomeLab/lemur-manuscript-archive that referenced this pull request Mar 4, 2020
@dhimmel
webpage.py: note to ignore error in versions checkout
663480f 
Merges manubot/rootstock#211
Closes manubot/rootstock#183
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agitter agitter agitter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

git --work-tree=webpage checkout gh-pages -- v logs error for new manuscripts
3 participants
@dhimmel @slochower @agitter