Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update setup.py #9

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

blastak
Copy link

@blastak blastak commented Aug 8, 2022

Hello,

Nice to see your amazing python program. It will be used in my biometrics project.
I am using python in a non-ANSI Windows environment, and when I run the pip install pyeer command, the following error occurs.

(kbid-pet-eval) C:\Users\raykim\Documents\kbid>pip install pyeer
Collecting pyeer
  Downloading pyeer-0.5.5.tar.gz (605 kB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 605.0/605.0 kB 19.2 MB/s eta 0:00:00
  Preparing metadata (setup.py) ... error
  error: subprocess-exited-with-error

  × python setup.py egg_info did not run successfully.
  │ exit code: 1
  ╰─> [6 lines of output]
      Traceback (most recent call last):
        File "<string>", line 36, in <module>
        File "<pip-setuptools-caller>", line 34, in <module>
        File "C:\Users\raykim\AppData\Local\Temp\pip-install-t358nolv\pyeer_07e334e579a845f7b7a1eec23e51bd61\setup.py", line 7, in <module>
          readme = f.read()
      UnicodeDecodeError: 'cp949' codec can't decode byte 0xe2 in position 8826: illegal multibyte sequence
      [end of output]

  note: This error originates from a subprocess, and is likely not a problem with pip.
error: metadata-generation-failed

× Encountered error while generating package metadata.
╰─> See above for output.

note: This is an issue with the package mentioned above, not pip.
hint: See above for details.

Therefore, the following code has been added for countries using non-ANSI Windows.

encoding='utf-8'

I make a pull request with the above code.
Thank you in advance.

PS. This is the result of successful installation after modifying the code.

(kbid-pet-eval) C:\Users\raykim\Documents\kbid\pyeer-master>pip install .
Processing c:\users\raykim\documents\kbid\pyeer-master
  Preparing metadata (setup.py) ... done
Collecting numpy
  Using cached numpy-1.21.6-cp37-cp37m-win_amd64.whl (14.0 MB)
Collecting matplotlib
  Downloading matplotlib-3.5.2-cp37-cp37m-win_amd64.whl (7.2 MB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 7.2/7.2 MB 35.5 MB/s eta 0:00:00
Collecting packaging>=20.0
  Using cached packaging-21.3-py3-none-any.whl (40 kB)
Collecting python-dateutil>=2.7
  Using cached python_dateutil-2.8.2-py2.py3-none-any.whl (247 kB)
Collecting kiwisolver>=1.0.1
  Downloading kiwisolver-1.4.4-cp37-cp37m-win_amd64.whl (54 kB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 54.9/54.9 kB ? eta 0:00:00
Collecting fonttools>=4.22.0
  Downloading fonttools-4.34.4-py3-none-any.whl (944 kB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 944.1/944.1 kB 30.1 MB/s eta 0:00:00
Collecting cycler>=0.10
  Downloading cycler-0.11.0-py3-none-any.whl (6.4 kB)
Collecting pillow>=6.2.0
  Downloading Pillow-9.2.0-cp37-cp37m-win_amd64.whl (3.3 MB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 3.3/3.3 MB 51.8 MB/s eta 0:00:00
Collecting pyparsing>=2.2.1
  Using cached pyparsing-3.0.9-py3-none-any.whl (98 kB)
Collecting typing-extensions
  Downloading typing_extensions-4.3.0-py3-none-any.whl (25 kB)
Collecting six>=1.5
  Using cached six-1.16.0-py2.py3-none-any.whl (11 kB)
Building wheels for collected packages: pyeer
  Building wheel for pyeer (setup.py) ... done
  Created wheel for pyeer: filename=pyeer-0.5.5-py3-none-any.whl size=601445 sha256=86a37511d40c3b597740f90a21c4fb0c544a0cbf4f58d15df4db4f072c291bee
  Stored in directory: c:\users\raykim\appdata\local\pip\cache\wheels\48\12\bd\788637326276f09912cf4128cb17374c425f6883c04235ac08
Successfully built pyeer
Installing collected packages: typing-extensions, six, pyparsing, pillow, numpy, fonttools, cycler, python-dateutil, packaging, kiwisolver, matplotlib, pyeer
Successfully installed cycler-0.11.0 fonttools-4.34.4 kiwisolver-1.4.4 matplotlib-3.5.2 numpy-1.21.6 packaging-21.3 pillow-9.2.0 pyeer-0.5.5 pyparsing-3.0.9 python-dateutil-2.8.2 six-1.16.0 typing-extensions-4.3.0

@@ -1,3 +1,33 @@
# conda 기준 사용법
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you please add these changes as a subsection of the installing section?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants