Improve coverage

manuelro · May 29, 2017 · 869a2d9 · 869a2d9
1 parent 99a89db
commit 869a2d9
Show file tree

Hide file tree

Showing 3 changed files with 53 additions and 4 deletions.
diff --git a/.nyc_output/5084cd7a70bb652877178f4d238e88ea.json b/.nyc_output/5084cd7a70bb652877178f4d238e88ea.json
diff --git a/config/webpack/config.js b/config/webpack/config.js
@@ -53,10 +53,10 @@ class Config{
 
     if(!_.isEmpty(options)) plugin = pluginFunction.call(this, options);
 
-    if(!_.property(plugin, 'name'))
+    if(!_.isString(plugin.name))
       throw new Error('invalid-prop', 'The generated plugin must contain a name property');
 
-    if(!_.property(plugin, 'plugin'))
+    if(!_.isObject(plugin.plugin))
       throw new Error('invalid-prop', 'The generated plugin must contain a plugin property');
 
     if(!this.config.plugins) this.config.plugins = [];

diff --git a/config/webpack/tests/config.test.js b/config/webpack/tests/config.test.js
@@ -25,10 +25,58 @@ describe( 'webpack', function() {
 
   describe( 'method', function ( ) {
 
-    describe( 'preset', function () {
+    describe( 'setPreset', function () {
       describe( 'when passed other value than "drupal"', function(){
         it( 'should throw', function () {
-          assert.throws( () => config.setPreset('wordpress'), Error );
+          assert.throws( () => webpack.setPreset('wordpress'), Error );
+        } );
+      } );
+    } );
+
+    describe( 'addPlugin', function () {
+      var pluginParams = {
+        funcWithName(){
+          return {
+            name: 'test',
+            plugin: function(){}
+          }
+        },
+        funcWithoutName(){
+          return {
+            plugin: function(){}
+          }
+        },
+        funcWithoutPlugin(){
+          return {
+            name: 'test'
+          }
+        }
+      }
+
+      beforeEach(function(){
+        webpack.options.plugins.test = { test: 'option' }
+        sinon.spy(pluginParams, 'funcWithName');
+      });
+
+      afterEach(function(){
+        pluginParams.funcWithName.restore();
+      });
+
+      describe( 'when passed param is not a function', function(){
+        it( 'should throw', function () {
+          assert.throws( () => webpack.addPlugin(), Error );
+        } );
+      } );
+
+      describe( 'when returned plugin config does not have a name', function(){
+        it( 'should throw', function () {
+          assert.throws( () => webpack.addPlugin(pluginParams.funcWithoutName), Error );
+        } );
+      } );
+
+      describe( 'when returned plugin config does not have a plugin', function(){
+        it( 'should throw', function () {
+          assert.throws( () => webpack.addPlugin(pluginParams.funcWithoutPlugin), Error );
         } );
       } );
     } );