Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed deprecated nativeWindowOpen option #156

Merged
merged 1 commit into from
Oct 10, 2022
Merged

Removed deprecated nativeWindowOpen option #156

merged 1 commit into from
Oct 10, 2022

Conversation

buneeIsSlo
Copy link
Contributor

fixes: #155

@buneeIsSlo
remove deprecated nativeWindowOpen option
442dedb 
Removed nativeWindowOpen option from webPreferences because it is deprecated.
@manusa manusa self-requested a review October 10, 2022 11:03
@sonarcloud
Copy link

sonarcloud bot commented Oct 10, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

manusa
manusa approved these changes Oct 10, 2022
View reviewed changes
Copy link
Owner

@manusa manusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx!

@manusa manusa merged commit 57879f2 into manusa:main Oct 10, 2022
@buneeIsSlo
Copy link
Contributor Author

@manusa Thank you for the opportunity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manusa manusa manusa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove deprecated nativeWindowOpen option from webPreferences in chrome-tabs module
2 participants
@buneeIsSlo @manusa