Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

One line not show after markdown be rendered #35

Closed
personball opened this issue Feb 14, 2023 · 3 comments
Closed

One line not show after markdown be rendered #35

personball opened this issue Feb 14, 2023 · 3 comments

Comments

@personball
Copy link
Contributor

I found this line not show when the markdown text rendered. Maybe by, I guess the Xml Tag not closed.

<GCEvent GCNumber="9" GCGeneration="0" Reason="AllocSmall">

Should we mark these lines as code block like:

<GCEvent GCNumber="9" GCGeneration="0" Reason="AllocSmall">
<GlobalHeapHistory **FinalYoungestDesired="9,830,400"** NumHeaps="12"/> 

But FinalYoungestDesired="9,830,400" in the code block not bold.

@Maoni0
Copy link
Owner

Maoni0 commented Feb 18, 2023

I think your code block idea is better. FinalYoungestDesired="9,830,400" wouldn't be bold but since it's already mentioned in the explanation it should be ok. would you like to submit a PR to fix this? 🙂

personball added a commit to personball/mem-doc that referenced this issue Feb 20, 2023
@personball personball mentioned this issue Feb 20, 2023
@personball
Copy link
Contributor Author

@Maoni0 please review pr #37

@Maoni0 Maoni0 closed this as completed in ed01fb5 Feb 20, 2023
@Maoni0
Copy link
Owner

Maoni0 commented Feb 20, 2023

cool, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants