Skip to content
This repository has been archived by the owner on Sep 21, 2024. It is now read-only.

refactor: update utils file #6

Merged
merged 1 commit into from
Jun 27, 2023
Merged

refactor: update utils file #6

merged 1 commit into from
Jun 27, 2023

Conversation

HiImFelipe
Copy link
Collaborator

What was done

  • Created a function that resets undefined samples;
    • Moved the comment line to said function;
  • Removed the else keyword usage to avoid unnecessary nesting;
  • Typed hitsoundableTimeLineObject properly;
  • Created a few consts for better naming;

@HiImFelipe HiImFelipe self-assigned this Jun 27, 2023
maotovisk
maotovisk approved these changes Jun 27, 2023
View reviewed changes
Copy link
Owner

@maotovisk maotovisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@maotovisk maotovisk merged commit be6bcd3 into dev Jun 27, 2023
@HiImFelipe HiImFelipe deleted the refactor/update-utils-file branch June 27, 2023 11:50
@HiImFelipe HiImFelipe added the enhancement New feature or request label Jun 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@maotovisk maotovisk maotovisk approved these changes

Assignees

@HiImFelipe HiImFelipe

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HiImFelipe @maotovisk