Skip to content
This repository has been archived by the owner on Oct 24, 2019. It is now read-only.

Refactoring to work with Slack's API changes #88

Closed
k-mahoney opened this issue Sep 26, 2017 · 3 comments
Closed

Refactoring to work with Slack's API changes #88

k-mahoney opened this issue Sep 26, 2017 · 3 comments
Assignees

Comments

@k-mahoney
Copy link
Contributor

k-mahoney commented Sep 26, 2017

Slack announced that they are removing the username object from their API and will now only support a mutable display_name object and the full user id - W012A3CDE.

https://api.slack.com/changelog/2017-09-the-one-about-usernames

Currently we track the username in our employee database, which is what we query to associate the GitHub username or other IDs from the initial alarm with the Slack user. We will no longer be able to rely on this.

Some initial thoughts on how to pivot and account for this change...

  • Replace the stored Slack username with the full, immutable user id in internal database
  • Further improve fallback and error handling for missing username cases

/cc @mapbox/security

@k-mahoney k-mahoney changed the title Refactoring to work with Slack Refactoring to work with Slack's API changes Sep 26, 2017
@k-mahoney
Copy link
Contributor Author

Noting that we technically have until September 12, 2018 when Slack drops support for the username object, but are already running into problems with users that have null usernames. Will prioritize updating for Slack's changes, error handling for missing usernames is in place via https://github.com/mapbox/dispatch/pull/78.

@k-mahoney
Copy link
Contributor Author

In progress in https://github.com/mapbox/dispatch/pull/116

@k-mahoney k-mahoney reopened this Feb 9, 2018
@k-mahoney
Copy link
Contributor Author

Complete in #116

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant