Fix feature pagination #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -331,7 +330,10 @@ var Cardboard = module.exports = function(config) { | |||
| } | |||
|
|
|||
| pageOptions = pageOptions || {}; | |||
| if (pageOptions.start) opts.start = pageOptions.start; | |||
| if (pageOptions.start) opts.start = { | |||
There was a problem hiding this comment.
If you roll this with mapbox/dyno#104 the wire-formatting here would go away, right? That would be nice
willwhite
force-pushed
the
fix-paging
branch
from
056ee68
to
8b7bbdc
Compare
willwhite
force-pushed
the
fix-paging
branch
from
76c9204
to
b14e499
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes pagination of features in cardboard and the test that was failure to catch this problem.
/cc @rclark