Unique id for each feature

[mick]

• generate a unique Id for each feature
• return in callback from insert
• add to geometry as feature.id
• add user provided id as GSI added to main index with a different prefix.
• query by user provided id

ref #44

[willwhite]

yay 👍

[rclark]

Question: What if a user provides a feature with an id specified outside properties? I thought that we were going to convert this input feature:

{
  "id": "user-id",
  "properties": { "stuff": "things" }
}

... into this on the way out:

{
  "id": "mapbox-id",
  "properties": {
    "id": "user-id",
    "stuff": "things"
  }
}

[mick]

Yeah we should do that. What do you think we should do if both feature.id and feature.properties.id exist?

[mick]

Actually we already talked about having feature.id mean update. So cant move the id to feature.properties.id which is happening in #45

[willwhite]

Right, we should require that any user-defined id be specified inside
properties. Magically moving the id property around in this way would
not actually help the user very much, because they would have to know where
to look for it again anyway.

On Thursday, September 4, 2014, Mick Thompson notifications@github.com
wrote:

Actually we already talked about having feature.id mean update. So cant
move the id to feature.properties.id which is happening in #45
#45

—
Reply to this email directly or view it on GitHub
#48 (comment).

202-250-3633 | will@mapbox.com | @willwhitedc