Skip to content
This repository has been archived by the owner on Jan 12, 2024. It is now read-only.

Avoid serializing empty Parameters #348

Closed
springmeyer opened this issue May 28, 2014 · 1 comment
Closed

Avoid serializing empty Parameters #348

springmeyer opened this issue May 28, 2014 · 1 comment
Labels
enhancement needs-test
Milestone
0.18

Comments

@springmeyer
Copy link

Carto currently dumps things like:

<Parameter name="geometry_field"><![CDATA[]]></Parameter>

When unset objects are passed along from TileMill. We could save space and mapnik xml parsing time by avoiding dumping these.
@nebulon42 nebulon42 added this to the 0.18 milestone Jan 20, 2017
nebulon42 added a commit that referenced this issue Jan 23, 2017
@nebulon42
add test for #348
fa83982
@nebulon42
Copy link
Collaborator

I think https://github.com/mapbox/carto/blob/master/lib/carto/renderer.js#L185 makes sure that this does not happen. Added a test, which passes. But maybe I'm missing something specific. More information about the objects would be good.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement needs-test
Projects
None yet
Milestone
0.18
Development

No branches or pull requests
2 participants
@springmeyer @nebulon42