Skip to content
This repository has been archived by the owner on Jan 12, 2024. It is now read-only.

add possibility of global _properties object in MML #458

Merged
merged 1 commit into from Jan 7, 2017
Merged

add possibility of global _properties object in MML #458

merged 1 commit into from Jan 7, 2017

Conversation

nebulon42
Copy link
Collaborator

@nebulon42 nebulon42 commented Dec 23, 2016

References layers and their properties
fixes #450

I'm not yet sure which properties definition should be more important. Currently if both _properties and properties for a layer contain the same property properties wins. This cannot happen with TM2, but it is necessary to specify for carto.

@pnorman please try it out if it works for you.
cc @gravitystorm

@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 89.135% when pulling 81404bb on nebulon42:global-properties into e7c4d2b on mapbox:master.

@nebulon42 nebulon42 added this to the 0.17 milestone Dec 23, 2016
@pnorman
Copy link
Contributor

pnorman commented Dec 24, 2016

@pnorman please try it out if it works for you.

How would I test this in Kosmtik?

@nebulon42
Copy link
Collaborator Author

You could checkout this PR somewhere and link the git repository into node_modules/carto in Kosmtik. Or maybe even easier specify "carto": "nebulon42/carto#81404bb4c86b888c2f40892c5f9d9f0ae0da40a8" in Kosmtik's package.json (see https://docs.npmjs.com/files/package.json#github-urls for details).

@nebulon42 nebulon42 merged commit 0f89ac9 into mapbox:master Jan 7, 2017
@nebulon42 nebulon42 deleted the global-properties branch January 7, 2017 19:26
@pnorman
Copy link
Contributor

pnorman commented Jan 13, 2017

Confirming that this works.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support _properties key in tm2 projects
3 participants