Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stuck in Infinite For Loop #44

Closed
JeremyBYU opened this issue Feb 24, 2019 · 2 comments · Fixed by #49
Closed

Stuck in Infinite For Loop #44

JeremyBYU opened this issue Feb 24, 2019 · 2 comments · Fixed by #49
Labels
bug

Comments

@JeremyBYU
Copy link

Hi,
First I just wanted to say that this is great library! I found an issue where delaunator gets stuck in an infinite loop. This bug seems to affect JavaScript and C++ delaunator. Attached is the zip file containing a json file of the points that reproduce the issue. The loop occurs somewhere starting in this for loop: https://github.com/mapbox/delaunator/blob/master/index.js#L147

error.zip

I'll try to look into it myself later. Thanks!
@mourner mourner added the bug label Feb 27, 2019
mourner added a commit that referenced this issue Jun 19, 2019
@mourner
fix a rare race condition that caused infinite loop
3def25a 
Closes #44.
This was referenced Jun 19, 2019
Merged
Open
@mourner
Copy link
Member

mourner commented Jun 19, 2019

🎉 #49
image

@JeremyBYU
Copy link
Author

Wow thank you for fixing this!

soerendd pushed a commit to soerendd/delaunator-cpp that referenced this issue Aug 5, 2019
@soerenmuehlbauer
Backport from delaunator-js for
f55ced6 
mapbox/delaunator#44
mapbox/delaunator#33

solves

delfrrr#11
delfrrr#16
@soerendd soerendd mentioned this issue Aug 5, 2019
Open
esilvia added a commit to esilvia/delaunator-cpp that referenced this issue Nov 4, 2020
@esilvia
Fixed issue-16
c928fc1 
Fixes delfrrr#16 to prevent infinite recursion when a triangle was previously deleted from hull_next.

Port of fix in original JavaScript mapbox/delaunator#44
@esilvia esilvia mentioned this issue Nov 4, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix a race condition that caused an infinite loop mapbox/delaunator
2 participants
@mourner @JeremyBYU