Skip to content
This repository has been archived by the owner on Jun 12, 2024. It is now read-only.

create versionSort function #117

Merged
merged 3 commits into from
Mar 5, 2019
Merged

create versionSort function #117

merged 3 commits into from
Mar 5, 2019

Conversation

katydecorah
Copy link
Contributor

This PR creates a helper function to sort version numbers for the API reference dropdowns

@katydecorah
Copy link
Contributor Author

@colleenmcginnis

  • When creating tests for the helper function, the console insisted that I update the babel versions so that's why you'll see some updates to babel and using the namespaced versions.
  • I copied the version-sort.js file and pasted it (temporarily) into the iOS PR so we can test this function. Once we feel good about it, then we can do a release and update the iOS PR

@colleenmcginnis
Copy link
Contributor

@katydecorah I'm getting this error after running npm ci and then npm start 🤔 :

module.js:557
    throw err;
    ^

Error: Cannot find module 'babel-core'
...

@katydecorah
Copy link
Contributor Author

@colleenmcginnis whoops! I pushed a fix to update babelify to fix that error 🙈

Copy link
Contributor

@colleenmcginnis colleenmcginnis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@katydecorah this looks amazing!! The tests work as I'd expect, and the temporary commit to /ios-sdk works perfectly. 👌

@katydecorah katydecorah merged commit 8930d1b into master Mar 5, 2019
@katydecorah katydecorah deleted the versionSort branch March 5, 2019 21:08
katydecorah pushed a commit that referenced this pull request Apr 17, 2019
* master: (22 commits)
  fixes bug in firefox where arrow was not vertically centered (#122)
  add swiftype attribute to ignore content blocks (#119)
  0.9.0
  Prepare 0.9.0
  Add BetaFlag component and options to add it to other components (#123)
  Prepare 0.8.1
  [patch] Use babel.config.js and updates build-package.js to output directories (#118)
  Prepare 0.8.0
  create versionSort function (#117)
  Prepare 0.7.0
  Add optional prop for tags for first level items in NavigationAccordion (#115)
  Prepare 0.6.0
  [docs-prose.css] make `.prose pre` rules more specific (#113)
  Add `mb24` to `OverviewHeader` (#112)
  [SectionedNavigation] filter the description if it's available (#111)
  Prepare 0.5.0
  Add warning and error themes to `Note` (#102)
  Add CSS to set max-height and style scrollbars for prose code examples (#103)
  [Card/CardContainer] Add new styles for fullwidth cards (#104)
  Add prism.css to create shared syntax styles used commonly across sites (#108)
  ...
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants