Create themes component to house shared themes for Tag and Note #217
Conversation
* master: Rework Notes themes (#202)
Co-Authored-By: Katy DeCorah <decorah@mapbox.com>
* refactor-tag-n-flag: update changelog add custom styling prop to related components use @katydecorah's suggestion Add new related page component (#213)
* master: Add a tag component with themes (#216)
* master: Collapse grayed lines in code block (#206)
src/components/themes/themes.js
Outdated
| themes.legacy.label = 'Legacy'; | ||
| (themes.legacy.tooltipText = | ||
| 'This feature is no longer in active development.'), | ||
| (themes.new = Object.assign({}, themes.beta)); |
There was a problem hiding this comment.
Now that the default theme is gray (and blue is available), what do you think about using blue for either new or beta?
There was a problem hiding this comment.
wowowowowow blue for beta!!!!!!!
There was a problem hiding this comment.
I like the blue! Just want to flag that the color of links is the same color as the text:
@colleenmcginnis I think it's fine since links are underscored, but wanted to double check with you!
There was a problem hiding this comment.
Ohhh and icon, maybe plus symbol for new?
There was a problem hiding this comment.
@colleenmcginnis I think it's fine since links are underscored, but wanted to double check with you!
I think /help pages have custom CSS that removed the underline 😬 but maybe we should change that for consistency anyway!
There was a problem hiding this comment.
@colleenmcginnis yeah let's make sure /help underscores links since that's a best practice 🤠
* master: Update CHANGELOG.md Update CHANGELOG.md allow `feedbackSentryDsn` to accept string (url) or boolean (false) conditionally set `section` and `preferredLanguage`; send along `environment`
* master: Create themes component to house shared themes for Tag and Note (#217)
* master: (32 commits) add missing indices (#219) Create `Edit` and `CodeSnippet` components (#197) Update CHANGELOG.md Update CHANGELOG.md create highlight/theme-css Create themes component to house shared themes for Tag and Note (#217) Update CHANGELOG.md Update CHANGELOG.md Collapse grayed lines in code block (#206) Add a tag component with themes (#216) Add new related page component (#213) Rework Notes themes (#202) Add "tag" option to second and third level headings (#212) Update style of BetaFlag (#207) allow `feedbackSentryDsn` to accept string (url) or boolean (false) Add IE11 compatibility for the `Search` component (#203) conditionally set `section` and `preferredLanguage`; send along `environment` Prepare 0.24.0 Add groovy highlight option (#201) Push text feedback to Sentry (#198) ...
Blocked by #216
This PR adds a Theme "component", using quotes here since it exports a JSON object, that stores shared theme data for
TagandNote. This PR also tests the color contrast between the background color and color in Themes to help make sure they are accessible.To test: