Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix description of area() #109

Closed
wants to merge 2 commits into from
Closed

fix description of area() #109

wants to merge 2 commits into from

Conversation

donbright
Copy link

that appears to be the wedge product, aka area of parallelogram, not triangle. it is twice the area of the triangle. example with points 0,0. 4,0. 4,3. area() = 12, triangle area = 6. thx

that appears to be the wedge product, aka area of parallelogram, not triangle. it is twice the area of the triangle. example  with points 0,0. 4,0.  4,3.   area() = 12, triangle area = 6. thx
Copy link
Member

@mourner mourner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Parallelogram" would probably be confusing here. In this case we're only interested in the sign so it doesn't matter if it's signed; we could just add a comment that it's double the signed area.

@mrgreywater
Copy link
Collaborator

To be honest, I also stumbled upon this, and came to the conclusion of @mourner, but maybe it would make sense to rename both the area and signedArea function to something like doubleArea and doubleSignedArea respectively to indicate their result is twice as large.

@mourner
Copy link
Member

mourner commented Dec 12, 2018

Another common pattern is to name the function orient.

Copy link
Author

@donbright donbright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

attempt to fit to issue discussion

@donbright
Copy link
Author

added comment it is twice signed area. thx.
this is a math function which has many different names depending on what branch of math the reader has studied.

@donbright
Copy link
Author

oops, i deleted my repo on accident. closing since it cannot be merged.

@donbright donbright closed this Apr 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants