Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial implementation of CLI [ready] #13

Merged
merged 31 commits into from
Dec 8, 2015
Merged

Initial implementation of CLI [ready] #13

merged 31 commits into from
Dec 8, 2015

Conversation

perrygeo
Copy link
Contributor

In addition to the existing geocoding command, this PR adds the following:

  • directions
  • distance
  • staticmap
  • surface
  • upload

Some usage examples here: https://github.com/mapbox/mapbox-cli-py/blob/api-stubs/README.md

I'd consider this about a 30% design, working but still much to do with regards to:

  • specifying input geodata (see Input waypoints #11)
  • figure out why travis is failing
  • more robust unit testing/ full coverage almost full coverage
  • docs (most likely just print the help text to the README for now)
  • getting more eyes on it for live testing & interface feedback
  • testing uploads (need to mock s3)
  • review language (plural-vs-singular forms of commands, help text editing, etc)
  • s/x-mapbox/mapbox/g

closes #2, closes #3, closes #4, closes #5, closes #6

@perrygeo perrygeo changed the title Initial implementation of CLI Initial implementation of CLI [not ready] Nov 25, 2015
@perrygeo perrygeo mentioned this pull request Dec 4, 2015
@perrygeo
Copy link
Contributor Author

perrygeo commented Dec 4, 2015

At this point we're at 90% coverage.

Aside from the s3 mock issue blocking testing of uploads, the only lines left uncovered are the raise MapboxCLIException(res.text.strip()) lines after a non-successful HTTP response code. Since we'd be mocking that response anyways and not testing any new pathways through the code, I don't think that's a blocker, at least not for a < 1.0 release.

@perrygeo
Copy link
Contributor Author

perrygeo commented Dec 7, 2015

We're now at 97% coverage missing only the non-successful HTTP response code handling.

@perrygeo
Copy link
Contributor Author

perrygeo commented Dec 7, 2015

@sgillies : When do we s/x-mapbox/mapbox/g?

@perrygeo
Copy link
Contributor Author

perrygeo commented Dec 8, 2015

we'll get 👀 on it once it's merged

@perrygeo perrygeo changed the title Initial implementation of CLI [not ready] Initial implementation of CLI [ready] Dec 8, 2015
sgillies added a commit that referenced this pull request Dec 8, 2015
Initial implementation of CLI [ready]
@sgillies sgillies merged commit b87a04f into master Dec 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants