Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests should not fight with user's MAPBOX_ACCESS_TOKEN #54

Merged
merged 2 commits into from
Feb 22, 2016
Merged

tests should not fight with user's MAPBOX_ACCESS_TOKEN #54

merged 2 commits into from
Feb 22, 2016

Conversation

perrygeo
Copy link
Contributor

fixes #33

@perrygeo perrygeo changed the title don't fight with user's MAPBOX_ACCESS_TOKEN tests should not fight with user's MAPBOX_ACCESS_TOKEN Feb 15, 2016
@perrygeo
Copy link
Contributor Author

Another example of a coveralls check gone wrong. Coverage decreased -(0.0%) to 94.074% - really? There is literally no difference in the number of lines covered according to coveralls itself:

screen shot 2016-02-16 at 10 22 03 am

@perrygeo perrygeo modified the milestone: 0.3 Feb 17, 2016
sgillies added a commit that referenced this pull request Feb 22, 2016
@sgillies
Merge pull request #54 from mapbox/token-case
e1a0498 
tests should not fight with user's MAPBOX_ACCESS_TOKEN
@sgillies sgillies merged commit e1a0498 into master Feb 22, 2016
@sgillies sgillies deleted the token-case branch February 22, 2016 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.3
Development

Successfully merging this pull request may close these issues.

Tests fail when MAPBOX_ACCESS_TOKEN is set
2 participants
@perrygeo @sgillies