StopTelemetryService obtainBoundInstances bug fix #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add null check to prevent crash when stopping telemetry service under certain cirucmstances
andrlee
suggested changes
Sep 25, 2018
| @@ -468,9 +468,11 @@ private void unbindTelemetryService() { | |||
| private void stopTelemetryService() { | |||
| TelemetryLocationEnabler.LocationState telemetryLocationState = telemetryLocationEnabler | |||
There was a problem hiding this comment.
shouldn't null check be at this line? as well as should we escape early?
if (telemetryService == null) { /* log error */ return; }
- change location of null check and return early to optimize system
- check telemetryService before making any changes
andrlee
approved these changes
Sep 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Under certain circumstances,
telemetryServiceis null and causes a crash when callingobtainBoundInstances()withinstopTelemetryService. Add in check to prevent crash.Fixes #188