Fix FileAttachment Queue Bug #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add return statement to prevent adding event to queue
andrlee
suggested changes
Oct 3, 2018
| @@ -241,6 +241,10 @@ boolean optLocationOut() { | |||
| return isLocationOpted; | |||
| } | |||
|
|
|||
| EventsQueue getQueue() { | |||
There was a problem hiding this comment.
what is the benefit of exposing/relaxing access restriction to queue object? it seems you just want to check if queue is empty, can we instead expose boolean isQueueEmpty() api?
| @@ -473,6 +473,38 @@ public void checksSessionIdRotationIntervalNotUpdated() throws Exception { | |||
| assertFalse(notUpdatedSessionInterval); | |||
| } | |||
|
|
|||
| @Test | |||
| public void checksAppUserTurnstileNotQueued() throws Exception { | |||
| Context mockedContext = obtainNetworkConnectedMockedContext(); | |||
There was a problem hiding this comment.
is there a way to avoid mocking external classes (android framework and okhttp) in our tests?
| theMapboxTelemetry.enable(); | ||
| theMapboxTelemetry.push(whitelistedEvent); | ||
|
|
||
| assertEquals(0, theMapboxTelemetry.getQueue().queue.size()); |
There was a problem hiding this comment.
you could also do assertTrue(theMapboxTelemetry.isQueueEmpty()) if you'd expose boolean isQueueEmpty() api.
- create isQueueEmpty method - add to tests - remove mocking calls from within tests
- overload method accidentally split
- fix order of overload method
andrlee
suggested changes
Oct 3, 2018
| @@ -241,6 +241,10 @@ boolean optLocationOut() { | |||
| return isLocationOpted; | |||
| } | |||
|
|
|||
| Boolean isQueueEmpty() { | |||
There was a problem hiding this comment.
i'd suggest to avoid boxed types and use primitives, in this particular case boolean is the way to go.
andrlee
approved these changes
Oct 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent
FileAttachmentevent from being added to queue, in addition to sending it up through attachment logic.Add in unit test to confirm that
whitelistedevents are not added to queue.\Fixes #225