Fix pom artifactId for libcore dependency #340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ugly fix but there's no other way to override project name
electrostat
approved these changes
Feb 15, 2019
Codecov Report
@@ Coverage Diff @@
## master #340 +/- ##
=========================================
Coverage 53.75% 53.75%
Complexity 452 452
=========================================
Files 92 92
Lines 2755 2755
Branches 160 160
=========================================
Hits 1481 1481
Misses 1221 1221
Partials 53 53 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apps fail to resolve
libcoredue to incorrectartifactId. Fix is ugly but there's no better way to override project name property programmatically since it's readonly. Tested withmavenLocalandappmodule.