Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style pencil-v6 shows rendering artifacts and missing elements #943

Closed
fnicollet opened this issue Jan 17, 2015 · 2 comments
Closed

Style pencil-v6 shows rendering artifacts and missing elements #943

fnicollet opened this issue Jan 17, 2015 · 2 comments
Labels
Milestone

Comments

@fnicollet
Copy link
Contributor

Hello,

In issue #942 , i asked about the available styles apart from "bright-v6" and "outdoors-v6" and @ljbade redirected me to this part of the repo:
https://github.com/mapbox/mapbox-gl-styles/tree/mb-pages/styles

It has a few more styles that I have been experimenting with. The "pencil-v6" one looks pretty cool ! but there are some rendering artifacts, I believe because of the sprite dimension.
Here is a jsfiddle to show you the result:
http://jsfiddle.net/fnicollet/y0t6qgdn/

Another strange thing is that there seem to be a race condition of some kind, at least, it shows different results as you refresh the page. To test, open a private navigation window with the jsfiddle. It should show:
image

Rendering looks ok. Refresh the page. This is what you would get:
image

Refresh a third time and you will get the first result or the bugged one, it seems very random. Here is the sprite used by pencil-v6:
https://www.mapbox.com/mapbox-gl-styles/sprites/pencil.png
It is larger than the other ones because of the background. Maybe this hasn't been tested recently?

Also, if you zoom out, you will notice that the maritime borders are missing but maybe that's just wrong in the style definition?
image

If this issue should be submitted to https://github.com/mapbox/mapbox-gl-styles/, i would be happy to move (or duplicate) the issue but it looks like there are rendering issues in mapbox-gl-js as well

Fabien

@nickidlugash
Copy link

@fnicollet Thanks for ticketing. These are fixed in pencil-v7

Note that currently there is still a rendering issue with tiling: #972

@fnicollet
Copy link
Contributor Author

Thanks @nickidlugash , I just tried pencil-v7 and it works well :)

I can notice the bug #972 but only while zooming between zoom levels. When being at exactly a zoom level, there is no white border.

I found another rendering issue with pencil tho, I am going to open another ticket for it with details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants