Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Pencil style #29

Closed
nickidlugash opened this issue Jan 30, 2015 · 3 comments
Closed

Update Pencil style #29

nickidlugash opened this issue Jan 30, 2015 · 3 comments
Assignees
@nickidlugash

Comments

@nickidlugash
Copy link
Contributor

I don't think Pencil has been manually updated since...ever. It's pretty broken. I'll update it in the v7 branch.
@nickidlugash nickidlugash self-assigned this Jan 30, 2015
@jfirebaugh
Copy link
Contributor

Awesome. If all the rendering errors noted in mapbox/mapbox-gl-js#943 are due to style breakage, please close that out. Otherwise make a note of specific renderer issues. Thanks!

@ljbade
Copy link

ljbade commented Jan 30, 2015

Also please test with GL native on OSX/Linux since pencil was very broken on that last time I tried.

I will check it out on Android after you update it too.

@nickidlugash
Copy link
Contributor Author

This is done. Once image tiling is fixed, the sprite might need updating. This style should also be updated once you can write functions for -image properties.

@jfirebaugh I closed out mapbox/mapbox-gl-js#943.

@ljbade As we discussed in chat, I tested on OSX and the breakage is likely a renderer bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nickidlugash nickidlugash

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jfirebaugh @ljbade @nickidlugash