Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using fill-image and background-image creates visible borders #972

Closed
nickidlugash opened this issue Jan 30, 2015 · 8 comments
Closed

Using fill-image and background-image creates visible borders #972

nickidlugash opened this issue Jan 30, 2015 · 8 comments
Assignees
Labels

Comments

@nickidlugash
Copy link

There are white borders around images when fill-image is used:

screen shot 2015-01-30 at 4 52 57 pm

@nickidlugash nickidlugash changed the title Using fill-image creates visible borders Using fill-image and background-image creates visible borders Jan 30, 2015
@fnicollet
Copy link
Contributor

This issue only happens between "integer" zoom levels. If you use mapbox-gl-leaflet, which restrict the mapbox-gl layer to only integer zoom layers, you can't see the issue. But when you zoom in and out, you can see the borders appear during the animation.

Probably just a rounding pixel issue somewhere :)

@ansis ansis self-assigned this Feb 3, 2015
@ansis ansis closed this as completed in e732e78 Feb 3, 2015
@fnicollet
Copy link
Contributor

Hello,
Just updated and rebuilt. The issue still happens during the animation between integer zoom levels (say when zooming from zoom 8 to 7 or 7 to 8). Maybe a little less than before, but still.
Reproduced on Windows (not retina), on IE11

Fabien

@ansis ansis reopened this Feb 3, 2015
@ansis
Copy link
Contributor

ansis commented Feb 3, 2015

@fnicollet could you take a screenshot? thanks

@fnicollet
Copy link
Contributor

It happens during the animation so I had to take the screenshot during the short time of the zoom animation:

scr

@jfirebaugh jfirebaugh modified the milestone: v0.6.0 Feb 4, 2015
@fnicollet
Copy link
Contributor

Nevermind, I didn't update mapbox-gl-js properly (was on mb-pages, not master) and the issue is actually fixed in master, thanks for your help!

This issue can be closed

@mourner
Copy link
Member

mourner commented Mar 14, 2015

Yay!

@mourner mourner closed this as completed Mar 14, 2015
@mourner
Copy link
Member

mourner commented Mar 14, 2015

@fnicollet or was your comment related to #974?

@fnicollet
Copy link
Contributor

Issue #972 can be closed but #974 is still there :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants