Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve zoom on terrain with exaggeration 0 #11830

Merged
merged 1 commit into from
May 2, 2022
Merged

Resolve zoom on terrain with exaggeration 0 #11830

merged 1 commit into from
May 2, 2022

Conversation

astojilj
Copy link
Contributor

The regression is originally noticed in mobile SDK mapbox/mapbox-maps-ios#1279, where the same approach is ported from #11578.
It was incorrect to (mis)use exaggeration 0 with semantics of invalid exaggeration value. Using undefined instead.

Changelog:

Resolve zoom on terrain when terrain exaggeration gets set to 0.

Issue was also reproducible using fog.html debug page

Untitled.mov

Launch Checklist

  • briefly describe the changes in this PR
  • include before/after visuals or gifs if this PR includes visual changes
  • write tests for all new functionality
  • document any changes to public APIs
  • post benchmark scores
  • manually test the debug page
  • tagged @mapbox/map-design-team @mapbox/static-apis if this PR includes style spec API or visual changes
  • tagged @mapbox/gl-native if this PR includes shader changes or needs a native port
  • apply changelog label ('bug', 'feature', 'docs', etc) or use the label 'skip changelog'
  • add an entry inside this element for inclusion in the mapbox-gl-js changelog: <changelog></changelog>

The regression is originally noticed in mobile SDK mapbox/mapbox-maps-ios#1279, where the same approach is ported from #11578.
It was incorrect to (mis)use exaggeration 0 with semantics of invalid exaggeration value. Using undefined instead.
Copy link
Contributor

@karimnaaji karimnaaji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@karimnaaji karimnaaji merged commit 0a2530f into main May 2, 2022
@karimnaaji karimnaaji deleted the astojilj-3271 branch May 2, 2022 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants