Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert stencil mask skipping optimization #11848

Merged
merged 1 commit into from
May 4, 2022
Merged

Conversation

endanke
Copy link
Contributor

@endanke endanke commented May 4, 2022

Reverts: #11542 and #11546

Fixes an issue which was originally reported in gl-native, however it was also reproducible in gl-js and seems to be caused by the optimization above.

The exact root cause of the issue is still not fully clear, but it seems to happen with styles that have a large amount of line layers. It appears the flickering happens when the 256 limit of the stencil IDs is reached, so most likely the stencils are not correctly rendered with the optimization after clearing.

Launch Checklist

  • briefly describe the changes in this PR
  • include before/after visuals or gifs if this PR includes visual changes
  • write tests for all new functionality
  • document any changes to public APIs
  • post benchmark scores
  • manually test the debug page
  • tagged @mapbox/map-design-team @mapbox/static-apis if this PR includes style spec API or visual changes
  • tagged @mapbox/gl-native if this PR includes shader changes or needs a native port
  • apply changelog label ('bug', 'feature', 'docs', etc) or use the label 'skip changelog'
  • add an entry inside this element for inclusion in the mapbox-gl-js changelog: <changelog>Fixes an issue which causes line layers to flicker occasionally</changelog>

@endanke endanke force-pushed the endanke/revert-stencil-skip branch from e3679ee to 604b38e Compare May 4, 2022 13:08
@endanke endanke merged commit 84db3ce into main May 4, 2022
@endanke endanke deleted the endanke/revert-stencil-skip branch May 4, 2022 15:00
brncsk added a commit to brncsk/mapbox-gl-js that referenced this pull request May 5, 2022
@fr-an-k
Copy link

fr-an-k commented Jun 21, 2022

I'm still having this or similar issue: #12024 and a newly introduced bug, possibly because of this fix: #12023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants