Revert stencil mask skipping optimization #11848
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts: #11542 and #11546
Fixes an issue which was originally reported in gl-native, however it was also reproducible in gl-js and seems to be caused by the optimization above.
The exact root cause of the issue is still not fully clear, but it seems to happen with styles that have a large amount of line layers. It appears the flickering happens when the 256 limit of the stencil IDs is reached, so most likely the stencils are not correctly rendered with the optimization after clearing.
Launch Checklist
@mapbox/map-design-team
@mapbox/static-apis
if this PR includes style spec API or visual changes@mapbox/gl-native
if this PR includes shader changes or needs a native portmapbox-gl-js
changelog:<changelog>Fixes an issue which causes line layers to flicker occasionally</changelog>