Add support for fitBounds
and fitScreenCoordinates
on globe
#12211
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for
fitBounds
andfitScreenCoordinates
with globe projection by leveraging the method introduced in #12138:fitBounds
orfitScreenCoordinates
, redirect all internal calls to_cameraForBoxAndBearing
to the newly introduced method from Add support forcameraForBounds
on globe projection #12138 instead of the iterative approach performing frustum intersection by raymarching steps (which isn't adapted for globe)._cameraForBounds
in order to be on par with previous behavior from the iterative frustum approach.Fixes https://github.com/mapbox/gl-js-team/issues/502
Launch Checklist
@mapbox/gl-native
if this PR includes shader changes or needs a native portmapbox-gl-js
changelog:<changelog>Add support for fitBounds and fitScreenCoordinates with globe projection</changelog>