Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrectly shaded concave corner of fill extrusions when AO is enabled #12214

Merged
merged 1 commit into from
Sep 5, 2022

Conversation

akoylasar
Copy link
Contributor

@akoylasar akoylasar commented Sep 5, 2022

When rounded edges and AO for fill extrusions are enabled simultaneously the concave corners between the walls are shaded incorrectly as seen below:

before-1

this PR resolves the issue and adds a render test verifying the fix:

after-1

Launch Checklist

  • briefly describe the changes in this PR
  • include before/after visuals or gifs if this PR includes visual changes
  • write tests for all new functionality
  • manually test the debug page
  • tagged @mapbox/gl-native if this PR includes shader changes or needs a native port
  • apply changelog label ('bug', 'feature', 'docs', etc) or use the label 'skip changelog'
  • add an entry inside this element for inclusion in the mapbox-gl-js changelog: <changelog>Fix incorrect shading of corners in fill extrusions when ambient occlusion is enabled.</changelog>

@akoylasar akoylasar self-assigned this Sep 5, 2022
@akoylasar
Copy link
Contributor Author

@mapbox/gl-native @astojilj @ivovandongen decided to merge this to include a render test before proceeding with the native PR.

@mourner mourner merged commit 8b7b431 into main Sep 5, 2022
@mourner mourner deleted the fouad/fix_FE_darkened_corners_when_ao_enabled branch September 5, 2022 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants