Fix missing ocean tiles #12279
Merged
Fix missing ocean tiles #12279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@avpeery I haven't been able to reproduce from my machine with this new epsilon value. Before moving this forward, it would be worth doing two things:
|
SnailBones
reviewed
Oct 11, 2022
| @@ -260,7 +260,8 @@ export class Terrain extends Elevation { | |||
| this._sourceTilesOverlap = {}; | |||
| this.proxySourceCache = new ProxySourceCache(style.map); | |||
| this.orthoMatrix = mat4.create(); | |||
| mat4.ortho(this.orthoMatrix, 0, EXTENT, 0, EXTENT, 0, 1); | |||
| const epsilon = this.painter.transform.projection.name === 'globe' ? .015 : 0; // Experimentally the smallest value to avoid rendering artifacts (https://github.com/mapbox/mapbox-gl-js/issues/11975) | |||
There was a problem hiding this comment.
Do we also need to check for terrain here?
There was a problem hiding this comment.
I'm not seeing the missing tile with terrain (no globe) with this fix, but will test out on various devices! I also hit a failed render test when I removed the globe check (no significant difference though)
There was a problem hiding this comment.
Here's a codesandbox with this change
avpeery
added
bug 🐞
and removed
skip changelog
karimnaaji
approved these changes
Oct 17, 2022
SnailBones
approved these changes
Oct 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11975. Similar logic to PR #12203, but epsilon value is only applied when globe projection and to the left bound (see definition for mat4.ortho here)
Test with codesandbox on different devices, many thanks!
Launch Checklist
mapbox-gl-jschangelog:<changelog>Fix missing ocean tiles when globe is enabled.</changelog>