Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MAPS3D-659] Remove unnecessary attribute in terrain related rendering code. #12472

Merged
merged 1 commit into from
Dec 19, 2022
Merged

[MAPS3D-659] Remove unnecessary attribute in terrain related rendering code. #12472

merged 1 commit into from
Dec 19, 2022

Conversation

akoylasar
Copy link
Contributor

@akoylasar akoylasar commented Dec 17, 2022 •
edited
Loading

This PR gets rid of an unnecessary attribute in the terrain related shader code thereby slightly improving GPU memory footprint.

Although unrelated an unused attribute in ground_shadow.vertex.glsl has also been removed.

cc @karimnaaji @mpulkki-mapbox @aleksigron

cc @mapbox/gl-native

Launch Checklist

  • briefly describe the changes in this PR
  • include before/after visuals or gifs if this PR includes visual changes
  • write tests for all new functionality
  • document any changes to public APIs
  • post benchmark scores
  • manually test the debug page
  • tagged @mapbox/map-design-team @mapbox/static-apis if this PR includes style spec API or visual changes
  • tagged @mapbox/gl-native if this PR includes shader changes or needs a native port
  • apply changelog label ('bug', 'feature', 'docs', etc) or use the label 'skip changelog'
  • add an entry inside this element for inclusion in the mapbox-gl-js changelog: <changelog>Improve rendering performance of terrain slightly by reducing its GPU memory footprint.</changelog>

@akoylasar akoylasar added the performance ⚡ Speed, stability, CPU usage, memory usage, or power usage label Dec 17, 2022
@akoylasar akoylasar requested a review from a team as a code owner December 17, 2022 23:02
@akoylasar akoylasar self-assigned this Dec 17, 2022
@akoylasar akoylasar merged commit 67ed1ab into main Dec 19, 2022
@akoylasar akoylasar deleted the fouad/terrain_improvements branch December 19, 2022 09:03
@akoylasar akoylasar changed the title Remove unnecessary attribute in terrain related rendering code. [MAPS3D-659] Remove unnecessary attribute in terrain related rendering code. Dec 19, 2022
@kallyas kallyas mentioned this pull request Jul 17, 2024
Merged
@yash509 yash509 mentioned this pull request Sep 16, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mourner mourner mourner approved these changes

Assignees

@akoylasar akoylasar

Labels
performance ⚡ Speed, stability, CPU usage, memory usage, or power usage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@akoylasar @mourner