-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable anisotropic filtering only beyond 20 degrees pitch #12577
Conversation
9d8aacd
to
787508a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! One final thing I'd check just in case is that the filter on draw doesn't incur any performance penalties, but otherwise good to go. Not sure what's going on with the CodeBuild failing but I guess that's a fluke.
I've run a benchmap, and it seems that the fix doesn't affect the rendering performance https://sites.mapbox.com/benchmap-js-results/runs/1358 |
Enable anisotropic filtering on tiles beyond 20 degrees pitch to prevent it from compromising image crispness on flat or low-tilted maps. This is a backport from GL Native. Closes #7331
mapbox-gl-js/src/render/draw_raster.js
Lines 81 to 85 in a3ef365
Also:
puppeteer-core
andselenium-webdriver
to the latest versionsLaunch Checklist
mapbox-gl-js
changelog:<changelog>Enable anisotropic filtering on tiles beyond 20 degrees pitch to prevent it from compromising image crispness on flat or low-tilted maps.</changelog>