Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

findStreetsSource causes setLanguage to fail #62

Open
tsmock opened this issue May 15, 2023 · 0 comments
Open

findStreetsSource causes setLanguage to fail #62

tsmock opened this issue May 15, 2023 · 0 comments

Comments

@tsmock
Copy link

tsmock commented May 15, 2023

findStreetsSource should check the actual version instead of the URL.

It fails with bright-v9 (https://api.mapbox.com/styles/v1/mapbox/bright-v9) and satellite-v9 (https://api.mapbox.com/styles/v1/mapbox/satellite-v9). Both styles are version: 8, but neither match the check (return url && url.indexOf('mapbox.mapbox-streets-v8') > -1 || /mapbox-streets-v[1-9][1-9]/.test(url);).

This check should probably be as follows:

return (style.version && style.version == 8) ||  (url && url.indexOf('mapbox.mapbox-streets-v8') > -1 || /mapbox-streets-v[1-9][1-9]/.test(url));
tsmock added a commit to facebook/OSM-HOT-Tasking-Manager that referenced this issue May 23, 2023
See mapbox/mapbox-gl-language#62

Signed-off-by: Taylor Smock <tsmock@meta.com>
tsmock added a commit to facebook/OSM-HOT-Tasking-Manager that referenced this issue May 24, 2023
See mapbox/mapbox-gl-language#62

Signed-off-by: Taylor Smock <tsmock@meta.com>
tsmock added a commit to facebook/OSM-HOT-Tasking-Manager that referenced this issue May 25, 2023
See mapbox/mapbox-gl-language#62

Signed-off-by: Taylor Smock <tsmock@meta.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant