Skip to content
This repository has been archived by the owner on Jun 21, 2023. It is now read-only.

Building framework now using mapbox-ios-sdk-gl-core-static instead of my custom mapbox-gl-native #434

Closed
nnhubbard opened this issue Sep 14, 2020 · 1 comment

Comments

@nnhubbard
Copy link

I have made modifications to mapbox-gl-native and when building the native-ios framework it previously built using my changes to mapbox-gl-native. Now, after updating mapbox-gl-native-ios with the latest commits, it seems to be using mapbox-ios-sdk-gl-core-static that it is downloading from https://api.mapbox.com/downloads/v2/carthage/mobile-maps-gl-core/mapbox-ios-sdk-gl-core-static.json and ignoring my custom changes in the vender folder for mapbox-gl-native. Why is this?

Steps to reproduce

  1. Update to latest mapbox-gl-native-ios
  2. Run make iframework BUILDTYPE=Release

Expected behavior

A Mapbox.framework file would be generate using my vendor/mapbox-gl-native which I have customized.

Actual behavior

It seems to no longer use vendor/mapbox-gl-native and use a static library downloaded instead. How can I get back to using my own changes that I have made in vendor/mapbox-gl-native?

Configuration

Mapbox SDK versions:
iOS/macOS versions: iOS 14
Device/simulator models: iPhone 11 Pro
Xcode version: 12, beta 6

@knov
Copy link
Contributor

knov commented Sep 16, 2020

@nnhubbard, Please see the note about v6.0.0 releases as it pertains to GL Native consumption and licensing.

mappy-mobile pushed a commit to Mappy/mapbox-gl-native-ios that referenced this issue Sep 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants