Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

QuickZoom zoom level after zooming in #11240

Closed
tobrun opened this issue Feb 19, 2018 · 3 comments
Closed

QuickZoom zoom level after zooming in #11240

tobrun opened this issue Feb 19, 2018 · 3 comments
Assignees
Labels
Android Mapbox Maps SDK for Android

Comments

@tobrun
Copy link
Member

tobrun commented Feb 19, 2018

ezgif com-video-to-gif 43 43

If you use the quick zoom gestures (double tap and hold) and you zoom based on y-amount of pixels and later zoom back in with same y amount, you don’t end up and the initial zoom level.

cc @LukasPaczos

@tobrun tobrun added the Android Mapbox Maps SDK for Android label Feb 19, 2018
@LukasPaczos LukasPaczos self-assigned this Feb 19, 2018
@LukasPaczos LukasPaczos added this to the android-v6.0.0 milestone Feb 19, 2018
@LukasPaczos
Copy link
Contributor

Debugging the issue I noticed that underlying ScaleGestureDetector can return suspicious values

D/MapGestureDetector$Scal: scale: factor - 1.1339383
D/MapGestureDetector$Scal: scale: factor - 1.0364736
D/MapGestureDetector$Scal: scale: factor - 0.84954655
D/MapGestureDetector$Scal: scale: factor - 1.3086545
D/MapGestureDetector$Scal: scale: below 0
D/MapGestureDetector$Scal: scale: factor - 0.84537005
D/MapGestureDetector$Scal: scale: factor - 0.8748795
D/MapGestureDetector$Scal: scale: factor - 0.94667435
D/MapGestureDetector$Scal: scale: factor - 1.0942392
D/MapGestureDetector$Scal: scale: factor - 1.2115576
D/MapGestureDetector$Scal: scale: factor - 1.2501236

adding clamping to that can result in uneven zoom effect.

We should tackle this issue with mapbox/mapbox-gestures-android#15.

@LukasPaczos
Copy link
Contributor

Decreasing the deadzone in mapbox/mapbox-gestures-android#30 helped a lot and I'm not feeling like this one is an issue anymore.
@tobrun, could you re-check release-boba on a device that you used for testing in the OP?

@tobrun
Copy link
Member Author

tobrun commented Apr 5, 2018

🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Android Mapbox Maps SDK for Android
Projects
None yet
Development

No branches or pull requests

2 participants