This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Parameter order for SAM interface for CustomGeometrySource #12010
Assignees
Labels
Android
Mapbox Maps SDK for Android
SEMVER-MAJOR
Requires a major release according to Semantic Versioning rules
Milestone
Comments
tobrun
added
Android
|
Landed in #13178 on |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Platform: Android
Mapbox SDK version: 6.1.1
The current parameter order the CustomGeometrySource makes it harder to use with Kotlin.
public CustomGeometrySource(String id, GeometryTileProvider provider, CustomGeometrySourceOptions options)Would be nicer as
public CustomGeometrySource(String id, CustomGeometrySourceOptions options, GeometryTileProvider provider)This is Googles recommendation for making Java libraries more Kotlin friendly.
https://android.github.io/kotlin-guides/interop.html#lambda-parameters-last
Minor issue, but a change to consider with the next major release. Or deprecating the current constructor and adding a new constructor.
The text was updated successfully, but these errors were encountered: