Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

OnDoubleTap doesn't trigger OnCameraChangeListener #4327

Closed
tobrun opened this issue Mar 15, 2016 · 4 comments
Closed

OnDoubleTap doesn't trigger OnCameraChangeListener #4327

tobrun opened this issue Mar 15, 2016 · 4 comments
Assignees
@tobrun
Labels
Android Mapbox Maps SDK for Android bug
Milestone
android-v4.0.0

Comments

@tobrun
Copy link
Member

tobrun commented Mar 15, 2016

When you perform a double tap, you are not receiving any OnCameraChangeListener updates.
@tobrun tobrun added bug Android Mapbox Maps SDK for Android labels Mar 15, 2016
@tobrun tobrun added this to the android-v4.0.0 milestone Mar 15, 2016
tobrun added a commit that referenced this issue Mar 15, 2016
@tobrun
[android] #4327 - double tap camera update change listener
ea7204a
@tobrun
Copy link
Member Author

tobrun commented Mar 15, 2016

After double checking the commit above doesn't fix it mainly because zoom is an animated transition and we should only invalidate after this event has occurred. Invalidating at that time, will not give us the correct values.

@tobrun tobrun mentioned this issue Mar 15, 2016
Closed
tobrun added a commit that referenced this issue Mar 21, 2016
@tobrun
[android] #4327 - OnDoubleTap needs to trigger camera invalidation af…
ca565a2 
…ter a zoom occurs
@tobrun
Copy link
Member Author

tobrun commented Mar 21, 2016

I'm working around this issue with a runnable/postdelayed solution for now.This has allmost no impact on the codebase for future releases we should migrate the zoom API to use the camera API but for this release it has too high impact to change it.

@tobrun tobrun mentioned this issue Mar 21, 2016
Closed
@tobrun
Copy link
Member Author

tobrun commented Mar 21, 2016

Created a new ticket to solve this for 4.1.0 in #4406

@tobrun tobrun mentioned this issue Mar 21, 2016
Merged
bleege pushed a commit that referenced this issue Mar 21, 2016
@tobrun @bleege
[android] #4327 - OnDoubleTap needs to trigger camera invalidation af…
8508aea 
…ter a zoom occurs
@bleege
Copy link
Contributor

bleege commented Mar 21, 2016

Merged into release-ios-3.2.0-android-4.0.0.

@bleege bleege closed this as completed Mar 21, 2016
@bleege bleege mentioned this issue Mar 21, 2016
Closed
14 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@tobrun tobrun

Labels
Android Mapbox Maps SDK for Android bug
Projects
None yet
Milestone
android-v4.0.0
Development

No branches or pull requests
3 participants
@jfirebaugh @bleege @tobrun