Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Put predicate property in protocol #6406

Closed
1ec5 opened this issue Sep 21, 2016 · 1 comment · Fixed by #6588
Closed

Put predicate property in protocol #6406

1ec5 opened this issue Sep 21, 2016 · 1 comment · Fixed by #6588
Assignees
@1ec5
Labels
iOS Mapbox Maps SDK for iOS macOS Mapbox Maps SDK for macOS refactor runtime styling

Comments

@1ec5
Copy link
Contributor

1ec5 commented Sep 21, 2016

A predicate property is declared redundantly on four out of six MGLBaseStyleLayer classes that conform to MGLStyleLayer. The property should instead be defined on an MGLSourceFiltering protocol that these four classes conform to.

/cc @frederoni @incanus
@1ec5 1ec5 added iOS Mapbox Maps SDK for iOS refactor macOS Mapbox Maps SDK for macOS runtime styling labels Sep 21, 2016
@1ec5 1ec5 mentioned this issue Sep 21, 2016
Closed
@1ec5 1ec5 self-assigned this Oct 5, 2016
This was referenced Oct 5, 2016
Closed
Merged
@1ec5
Copy link
Contributor Author

1ec5 commented Oct 5, 2016

In #6588, I ended up not putting the predicate property in a protocol, as proposed here. Instead, I had the classes that need this property inherit from a class that provides the property.

@1ec5 1ec5 closed this as completed in #6588 Oct 6, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@1ec5 1ec5

Labels
iOS Mapbox Maps SDK for iOS macOS Mapbox Maps SDK for macOS refactor runtime styling
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Revamp MGLStyleLayer, MGLSource inheritance mapbox/mapbox-gl-native
1 participant
@1ec5