Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Replace Proguard rules with @Keep annotations #8978

Closed
zugaldia opened this issue May 12, 2017 · 0 comments
Closed

Replace Proguard rules with @Keep annotations #8978

zugaldia opened this issue May 12, 2017 · 0 comments
Assignees
Labels
Android Mapbox Maps SDK for Android

Comments

@zugaldia
Copy link
Member

Currently, to define our minification rules we use a proguard-rules.pro file, which is error-prone because it needs to be manually updated with every release (e.g. #8944) and it's not directly connected with the code, making it easier to forget to include classes that need to be tracked.

Instead, we should explore replacing all or some of those rules with the @Keep annotation, which gets attached to its target and it's easier to update incrementally.

cc: @tobrun @Guardiola31337

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Android Mapbox Maps SDK for Android
Projects
None yet
Development

No branches or pull requests

4 participants